Conversation
🦋 Changeset detectedLatest commit: 65069f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
ggazzo
force-pushed
the
fix/empty-tag-result
branch
from
b6bc86a to
2149cf3
Compare
ggazzo
force-pushed
the
fix/empty-tag-result
branch
from
2149cf3 to
4a5563a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35028 +/- ##
========================================
Coverage 59.17% 59.17%
========================================
Files 2822 2822
Lines 68117 68117
Branches 15145 15145
========================================
Hits 40311 40311
Misses 24975 24975
Partials 2831 2831
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
changed the title
KevLehman
reviewed
Jan 24, 2025
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
KevLehman
previously approved these changes
Jan 24, 2025
ggazzo
added
the
stat: QA assured
juliajforesti
pushed a commit
that referenced
this pull request
Jan 28, 2025
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes a missconception about
/v1/livechat/tags/:tagIdthe type definition doesnt consider null/empty results
the code returns
ILivechatTag | { body: null }which is weird/wrong.now if we cannot find the tag returns a 404 result
Issue(s)
CORE-949
Steps to test or reproduce
Further comments